Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SR-IOV Device Plugin CDI support #473

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add SR-IOV Device Plugin CDI support #473

merged 1 commit into from
Oct 30, 2023

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jul 12, 2023

No description provided.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jul 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6547948168

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 25.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovnetworknodepolicy_controller.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 70.45%
controllers/sriovnetwork_controller.go 2 72.93%
pkg/apply/apply.go 2 74.29%
api/v1/helper.go 6 41.45%
controllers/sriovoperatorconfig_controller.go 7 53.44%
Totals Coverage Status
Change from base Build 6530802222: -0.2%
Covered Lines: 2256
Relevant Lines: 8966
💛 - Coveralls

SchSeba
SchSeba reviewed Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @e0ne should this be part of the sriovOperatorConfig and not env variable?

@e0ne
Copy link
Collaborator Author

e0ne commented Oct 3, 2023

Hi @e0ne should this be part of the sriovOperatorConfig and not env variable?

good point, I'll update my PR

@e0ne e0ne marked this pull request as ready for review October 3, 2023 15:53
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne e0ne requested a review from adrianchiris October 17, 2023 12:10
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris reviewed Oct 19, 2023
View reviewed changes
bindata/manifests/plugins/sriov-device-plugin.yaml Outdated
{{- if .UseCDI }}
- name: dynamic-cdi
mountPath: /var/run/cdi
- name: host-config-volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this one ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a leftover from the fist version of PR. it should be deleted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, so once removed im LGTM with this one.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update crd in helm chart as well. otherwise LGTM

Update: NVM its there already :)

zeeke
zeeke approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ready to merge if CI is green

@adrianchiris adrianchiris merged commit f622e38 into k8snetworkplumbingwg:master Oct 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@adrianchiris adrianchiris adrianchiris approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e0ne @coveralls @zeeke @SchSeba @adrianchiris